Review main Abandoned

58546[WIP][TASK] Add default aspectRatios for social share images

Josef Glatz CR 0 V 0 Hard +269 −188 updated 10/29/18, 09:54

Commit message

This patch disables the default cropVariant for the out-of-the-box
available social sharing images and adds well-known and suggested
aspect ratios.

The editor still can use a free aspect ratio to crop an image according
to his wishes. The configuration of cropVariants can still be extended
or adjusted via typical TCA/Overrides in own extensions.

ToDo's
-------------
- Wait until Richard have new insight's after meeting with Yoast team
- \TYPO3\CMS\Seo\MetaTag\MetaTagGenerator::generateSocialImages needs
  to be checked if images are generated correctly
- Important RsT
- re-check if it's possible to overwrite cropVariant "default" instead
  of creating a new one (which is possibly the only way)

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2