Review main Merged

58553[BUGFIX] Streamline PageTypeDecorator handling

Oliver Hader CR +2 V +2 Easy +19 −5 updated 10/06/18, 07:25

Commit message

* uses '&type=xyz' argument value of query in case no PageType decorator
  has been configured or if no value could be resolved (not defined in
  'map' nor as 'default' value)
* allows using 'default' value without having it defined in 'map' (values
  always should be explicit, however this is a fallback handling)

Review

  • Code review CR +2
    • Benni Mack +2
    • Stefan Neufeind +1
    • Daniel Goerz +1
    • Georg Ringer +1
    • Wouter Wolters +1
    • Richard Haeser +1
    • Andreas Kienast +1
  • Verified V +2
    • Benni Mack +2
    • Stefan Neufeind +1
    • Daniel Goerz +1
    • Georg Ringer +1
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1112

  1. Oliver Hader uploaded patch set 1 10/02/18, 06:52

  2. Georg Ringer voted on patch set 1 V +1 CR +1 10/02/18, 06:57

  3. Andreas Kienast voted on patch set 1 CR +1 10/02/18, 06:59

  4. TYPO3com voted on patch set 1 V +1 10/02/18, 07:10 Completed build in 14m 31s on Tue, 2 Oct, 09:10 AM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29261

  5. Richard Haeser voted on patch set 1 V +1 CR +1 10/02/18, 07:15

  6. Wouter Wolters voted on patch set 1 CR +1 10/02/18, 07:23

  7. Benni Mack voted on patch set 1 V +2 CR +2 10/02/18, 07:24

  8. Benni Mack merged patch set 2 10/02/18, 07:24

  9. Daniel Goerz voted on patch set 1 V +1 CR +1 10/02/18, 07:24

  10. Stefan Neufeind commented on patch set 2 V +1 CR +1 10/06/18, 02:12

    Without a patch failed to create a sitemap for http://localhost/?type=1533906435 (just showed page-type 0), works with the patch (creating a sitemap). The Sitemap still does not generate fine on my local installation - but that shouldn't be related to the parts this patch touches.
  11. Oliver Hader commented on patch set 2 10/06/18, 07:23

    @Stefan: Can you please create a new issue that shows the following? * your configuration for the PageTypeDecorator * the result with having this change applied * the result without having this change applied Thanks in advance!
  12. Richard Haeser commented on patch set 2 10/06/18, 07:25

    If I understand correctly, you have an issue with the XML Sitemap @stefan?