Review main Merged

58576[BUGFIX] Set correct language uids in MenuProcessor when set to auto

Nikita Hovratov CR +2 V +2 Easy +29 −1 updated 10/28/18, 11:33

Commit message

The configuration special.auto was introduced in #84775. The function
MenuProcessor->prepareLevelLanguageConfiguration() was not aware of that
and set the value for the languageUids to "auto".

Review

  • Code review CR +2
    • Benni Mack +2
    • Jasmina Ließmann +1
    • Daniel Goerz +1
    • Joerg Kummer +1
  • Verified V +2
    • Benni Mack +2
    • Jasmina Ließmann +1
    • Daniel Goerz +1
    • Joerg Kummer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Nikita Hovratov uploaded patch set 1 10/04/18, 14:50

  2. TYPO3com voted on patch set 1 V +1 10/04/18, 15:01 Completed build in 10m 45s on Thu, 4 Oct, 05:01 PM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29323

  3. Jörg Bösche commented on patch set 2 10/26/18, 10:11

    Published edit on patch set 1.
  4. TYPO3com voted on patch set 2 V +1 10/26/18, 10:23 Completed build in 12m 12s on Fri, 26 Oct, 12:23 PM Test Summary: 37819 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29585

  5. Daniel Goerz voted on patch set 2 V +1 CR +1 10/26/18, 11:04

  6. Jasmina Ließmann voted on patch set 2 V +1 CR +1 10/26/18, 11:21

  7. Joerg Kummer voted on patch set 2 V +1 CR +1 10/26/18, 13:57

  8. Benni Mack commented on patch set 2 CR -1 10/26/18, 15:09

    MenuProcessor.php:330

    should only be called when there is a Site, not a PseudoSite.
  9. Benni Mack commented on patch set 2 V +2 CR +2 10/28/18, 11:33

    ok for now.
  10. Benni Mack merged patch set 3 10/28/18, 11:33