Review main Merged

58583[TASK] Fix link in Changelog: Breaking-80929-TYPO3_DBMovedToExtension.rst

TYPO3com CR +2 V +2 Easy +2 −2 updated 10/10/18, 12:27

Commit message

Missing space between link text and link-href

Review

  • Code review CR +2
    • Riccardo De Contardi +2
    • Stefan Neufeind +1
  • Verified V +2
    • Riccardo De Contardi +2
    • Stefan Neufeind +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 711

  1. TYPO3com uploaded patch set 1 10/05/18, 16:06

  2. TYPO3com voted on patch set 1 V +1 10/05/18, 16:16 Completed build in 10m 39s on Fri, 5 Oct, 06:16 PM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29338

  3. Sybille Peters uploaded patch set 2 10/09/18, 14:06

  4. Sybille Peters commented on patch set 2 V +1 CR +1 10/09/18, 14:09

    I only changed the commit msg, not the original patch, so I think it's ok for me to do a review.
  5. TYPO3com voted on patch set 2 V +1 10/09/18, 14:18 Completed build in 11m 42s on Tue, 9 Oct, 04:18 PM Test Summary: 37801 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29379

  6. Stefan Neufeind commented on patch set 2 10/10/18, 09:45

    But do we need the added whitespace at the end of the line? At least in gerrit it looks (red marked) like there is a space too much which wasn't there before.
  7. Sybille Peters uploaded patch set 3 10/10/18, 12:05

  8. Stefan Neufeind commented on patch set 3 V +1 CR +1 10/10/18, 12:06

    nothing to really/easily verify here
  9. TYPO3com voted on patch set 3 V +1 10/10/18, 12:16 Completed build in 11m 02s on Wed, 10 Oct, 02:16 PM Test Summary: 37801 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29391

  10. Riccardo De Contardi voted on patch set 3 V +2 CR +2 10/10/18, 12:27

  11. Riccardo De Contardi merged patch set 4 10/10/18, 12:27