Review main Merged

58606[BUGFIX] Filelist: fix file/folder pasteFileInto in file tree context menu

Josef Glatz CR +2 V +2 Easy +7 −1 updated 10/11/18, 06:22

Commit message

Provide missing data attributes for the context menu paste action.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Daniel Goerz +1
    • Tomas Norre Mikkelsen +1
  • Verified V +2
    • Stefan Neufeind +2
    • Daniel Goerz +1
    • Tomas Norre Mikkelsen +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1214

  1. Josef Glatz uploaded patch set 1 10/10/18, 06:53

  2. Stefan Neufeind commented on patch set 1 V +1 10/10/18, 07:02

    without the patch I got a "TypeError: TYPO3.lang is undefined", probably because it tried to fetch default-labels? Is there some fix we can do about default-labels maybe? Works with the labels defined by this patch.
  3. Stefan Neufeind voted on patch set 1 CR +1 10/10/18, 07:02

  4. TYPO3com voted on patch set 1 V +1 10/10/18, 07:04 Completed build in 10m 56s on Wed, 10 Oct, 09:04 AM Test Summary: 37801 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29389

  5. Josef Glatz commented on patch set 1 10/10/18, 07:05

    > without the patch I got a "TypeError: TYPO3.lang is undefined", > probably because it tried to fetch default-labels? Is there some > fix we can do about default-labels maybe? > Works with the labels defined by this patch. Have on my list already. Is another issue/patch
  6. Alexander Grein voted on patch set 1 CR +1 10/10/18, 07:07

  7. Andreas Kienast voted on patch set 1 CR +1 10/10/18, 07:22

  8. Andreas Kienast commented on patch set 1 CR -1 10/10/18, 16:32

    FileProvider.php:369 Unresolved

    locallang_layout.xlf is Page module exclusive, we have to add the labels at another place.
  9. Andreas Kienast uploaded patch set 2 10/10/18, 16:43

  10. TYPO3com voted on patch set 2 V +1 10/10/18, 16:53 Completed build in 10m 17s on Wed, 10 Oct, 06:53 PM Test Summary: 37801 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29395

  11. Daniel Goerz voted on patch set 2 V +1 CR +1 10/10/18, 17:33

  12. Tomas Norre Mikkelsen voted on patch set 2 V +1 CR +1 10/11/18, 05:13

  13. Stefan Neufeind voted on patch set 2 V +2 CR +2 10/11/18, 06:22

  14. Stefan Neufeind merged patch set 3 10/11/18, 06:22