Review main Merged

58670[TASK] Remove duplicate XLIFF entry

Xavier Perseguers CR +2 V +2 Easy +0 −3 updated 10/30/18, 10:08

Commit message

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Jan Helke +2
    • Mathias Brodala +2
    • Stefan Neufeind +1
    • Georg Ringer +1
    • Preben Sørensen +1
    • Joerg Kummer +1
    • Andreas Kienast +1
    • Willi Wehmeier +1
  • Verified V +2
    • Wouter Wolters +2
    • Jan Helke +2
    • Mathias Brodala +2
    • Stefan Neufeind +1
    • Georg Ringer +1
    • Preben Sørensen +1
    • Andreas Kienast +1
    • Willi Wehmeier +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 2224

  1. Xavier Perseguers uploaded patch set 1 10/22/18, 09:15

  2. Mathias Brodala voted on patch set 1 V +2 CR +2 10/22/18, 09:16

  3. Mathias Brodala commented on patch set 1 CR -2 10/22/18, 09:22

    Waiting for Bamboo to be revived.
  4. Georg Ringer voted on patch set 1 V +1 CR +1 10/22/18, 09:37

  5. Willi Wehmeier voted on patch set 1 V +1 CR +1 10/22/18, 09:56

  6. Xavier Perseguers commented on patch set 1 V +1 10/22/18, 10:42

    Temporarily forced the use of the patch on the translation server and I confirm that the bug is indeed gone. TYPO3v9.filemapping then contains every TYPO3 v9 XLIFF files.
  7. Joerg Kummer voted on patch set 1 CR +1 10/22/18, 12:01

  8. Georg Ringer updated the commit message in patch set 2 10/22/18, 12:30

  9. TYPO3com voted on patch set 2 V +1 10/22/18, 12:40 Completed build in 10m 13s on Mon, 22 Oct, 02:40 PM Test Summary: 37807 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29506

  10. Preben Sørensen commented on patch set 2 V -1 CR -1 10/22/18, 12:42

    I tried the patch. Deleted all langfiles in typo3conf/l10n and typo3temp/var/cache/data/l10n. After updating Language Pack, the labels are still missing.
  11. Mathias Brodala commented on patch set 2 V +2 CR +2 10/22/18, 12:47

    > I tried the patch. Deleted all langfiles in typo3conf/l10n and > typo3temp/var/cache/data/l10n. After updating Language Pack, the > labels are still missing. Yes, because the translation server won't know about this change. We first must merge it to have the translation server pick it up.
  12. Xavier Perseguers commented on patch set 2 10/22/18, 12:48

    Exactly, and in addition, you will have to wait until tomorrow for the language packs to be rebuilt.
  13. Andreas Kienast voted on patch set 2 V +1 CR +1 10/22/18, 12:54

  14. Wouter Wolters voted on patch set 2 V +2 CR +2 10/22/18, 12:57

  15. Jan Helke voted on patch set 2 V +2 CR +2 10/22/18, 13:01

  16. Andreas Kienast updated the commit message in patch set 3 10/22/18, 13:08

  17. Andreas Kienast voted on patch set 3 V +1 CR +1 10/22/18, 13:08

  18. Mathias Brodala voted on patch set 3 V +2 CR +2 10/22/18, 13:12

  19. Jan Helke voted on patch set 3 V +2 CR +2 10/22/18, 13:15

  20. Wouter Wolters voted on patch set 3 V +2 CR +2 10/22/18, 13:17

  21. TYPO3com voted on patch set 3 V +1 10/22/18, 13:18 Completed build in 10m 45s on Mon, 22 Oct, 03:18 PM Test Summary: 37807 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29507

  22. Wouter Wolters merged patch set 4 10/22/18, 13:19

  23. Preben Sørensen voted on patch set 4 V +1 CR +1 10/23/18, 05:15

  24. Stefan Neufeind commented on patch set 4 V +1 CR +1 10/30/18, 10:08

    What a beast to debug, I guess. It broke having a clean translated backend upon LTS-launch :-( Works fine now finally, thanks a lot.