58670[TASK] Remove duplicate XLIFF entry
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Jan Helke +2
- Mathias Brodala +2
- Stefan Neufeind +1
- Georg Ringer +1
- Preben Sørensen +1
- Joerg Kummer +1
- Andreas Kienast +1
- Willi Wehmeier +1
-
Verified V +2
- Wouter Wolters +2
- Jan Helke +2
- Mathias Brodala +2
- Stefan Neufeind +1
- Georg Ringer +1
- Preben Sørensen +1
- Andreas Kienast +1
- Willi Wehmeier +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 2224
-
Xavier Perseguers uploaded patch set 1 10/22/18, 09:15
-
Mathias Brodala voted on patch set 1 V +2 CR +2 10/22/18, 09:16
-
Mathias Brodala commented on patch set 1 CR -2 10/22/18, 09:22
Waiting for Bamboo to be revived. -
Georg Ringer voted on patch set 1 V +1 CR +1 10/22/18, 09:37
-
Willi Wehmeier voted on patch set 1 V +1 CR +1 10/22/18, 09:56
-
Xavier Perseguers commented on patch set 1 V +1 10/22/18, 10:42
Temporarily forced the use of the patch on the translation server and I confirm that the bug is indeed gone. TYPO3v9.filemapping then contains every TYPO3 v9 XLIFF files. -
Joerg Kummer voted on patch set 1 CR +1 10/22/18, 12:01
-
Georg Ringer updated the commit message in patch set 2 10/22/18, 12:30
-
TYPO3com voted on patch set 2 V +1 10/22/18, 12:40 Completed build in 10m 13s on Mon, 22 Oct, 02:40 PM Test Summary: 37807 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29506
-
Preben Sørensen commented on patch set 2 V -1 CR -1 10/22/18, 12:42
I tried the patch. Deleted all langfiles in typo3conf/l10n and typo3temp/var/cache/data/l10n. After updating Language Pack, the labels are still missing. -
Mathias Brodala commented on patch set 2 V +2 CR +2 10/22/18, 12:47
> I tried the patch. Deleted all langfiles in typo3conf/l10n and > typo3temp/var/cache/data/l10n. After updating Language Pack, the > labels are still missing. Yes, because the translation server won't know about this change. We first must merge it to have the translation server pick it up. -
Xavier Perseguers commented on patch set 2 10/22/18, 12:48
Exactly, and in addition, you will have to wait until tomorrow for the language packs to be rebuilt. -
Andreas Kienast voted on patch set 2 V +1 CR +1 10/22/18, 12:54
-
Wouter Wolters voted on patch set 2 V +2 CR +2 10/22/18, 12:57
-
Jan Helke voted on patch set 2 V +2 CR +2 10/22/18, 13:01
-
Andreas Kienast updated the commit message in patch set 3 10/22/18, 13:08
-
Andreas Kienast voted on patch set 3 V +1 CR +1 10/22/18, 13:08
-
Mathias Brodala voted on patch set 3 V +2 CR +2 10/22/18, 13:12
-
Jan Helke voted on patch set 3 V +2 CR +2 10/22/18, 13:15
-
Wouter Wolters voted on patch set 3 V +2 CR +2 10/22/18, 13:17
-
TYPO3com voted on patch set 3 V +1 10/22/18, 13:18 Completed build in 10m 45s on Mon, 22 Oct, 03:18 PM Test Summary: 37807 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29507
-
Wouter Wolters merged patch set 4 10/22/18, 13:19
-
Preben Sørensen voted on patch set 4 V +1 CR +1 10/23/18, 05:15
-
Stefan Neufeind commented on patch set 4 V +1 CR +1 10/30/18, 10:08
What a beast to debug, I guess. It broke having a clean translated backend upon LTS-launch :-( Works fine now finally, thanks a lot.