Review main Merged

58723[BUGFIX] Use correct type for header value

Daniel Goerz CR +2 V +2 Easy +2 −2 updated 10/27/18, 11:55

Commit message

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Joerg Kummer +1
    • Jürgen Heym +1
    • Benni Mack +1
  • Verified V +2
    • Anja Leichsenring +2
    • Joerg Kummer +1
    • Jürgen Heym +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 912

  1. Daniel Goerz uploaded patch set 1 10/26/18, 17:28

  2. Daniel Goerz updated the commit message in patch set 2 10/26/18, 17:29

  3. TYPO3com voted on patch set 1 V +1 10/26/18, 17:40 Completed build in 11m 56s on Fri, 26 Oct, 07:40 PM Test Summary: 37819 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29625

  4. TYPO3com voted on patch set 2 V +1 10/26/18, 17:44 Completed build in 14m 42s on Fri, 26 Oct, 07:44 PM Test Summary: 37819 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29626

  5. Benni Mack commented on patch set 2 CR -1 10/27/18, 09:43

    TypoScriptFrontendController.php:4244

    Expire is no valid HTTP header name.
  6. Benni Mack commented on patch set 3 10/27/18, 09:45

    Published edit on patch set 2.
  7. Benni Mack voted on patch set 3 V +1 CR +1 10/27/18, 09:45

  8. TYPO3com voted on patch set 3 V +1 10/27/18, 09:59 Completed build in 14m 07s on Sat, 27 Oct, 11:59 AM Test Summary: 37819 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29639

  9. Joerg Kummer voted on patch set 3 V +1 CR +1 10/27/18, 11:08

  10. Jürgen Heym commented on patch set 3 V +1 CR +1 10/27/18, 11:51

    Unrelated change in line 4032 is acceptable ...
  11. Anja Leichsenring voted on patch set 3 V +2 CR +2 10/27/18, 11:55

  12. Anja Leichsenring merged patch set 4 10/27/18, 11:55