Review TYPO3_8-7 Merged

58772[BUGFIX] Allow unicode characters in verifyFileNameAgainstDenyPattern

Benni Mack CR +2 V +2 Normal +98 −12 updated 10/28/18, 16:44

Commit message

Using (valid) unicode characters in
GeneralUtility::verifyFilenameAgainstDenyPattern was not possible due
to a missing unicode modifier when evaluating regular expressions.
The unicode modifier has been added.
Since unicode errors in regular expressions will lead to `false`
results, it is important to perform type-safe checks against `0`.

Review

  • Code review CR +2
    • Benni Mack +2
  • Verified V +2
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 34

  1. Benni Mack uploaded patch set 1 10/28/18, 16:26

  2. TYPO3com voted on patch set 1 V +1 10/28/18, 16:35 Completed build in 09m 41s on Sun, 28 Oct, 05:35 PM Test Summary: 60212 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3133

  3. Benni Mack voted on patch set 1 V +2 CR +2 10/28/18, 16:44

  4. Benni Mack merged patch set 2 10/28/18, 16:44