Review main Merged

58779[BUGFIX] Render correct paging label

Andreas Kienast CR +2 V +2 Easy +4 −4 updated 10/29/18, 15:15

Commit message

In case of paging in any record list, the page browser is rendered in top
and on bottom of ther record list.

The upper browser now renders the paging correctly by calculating the
offset of items of the previous page instead of hard-coding a "1".

Review

  • Code review CR +2
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2
    • Benni Mack +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 811

  1. Andreas Kienast uploaded patch set 1 10/29/18, 13:58

  2. Andreas Kienast commented on patch set 1 10/29/18, 13:59

    The backports require adjustments in AbstractRecordList only
  3. Andreas Kienast uploaded patch set 2 10/29/18, 14:03

  4. TYPO3com voted on patch set 1 V +1 10/29/18, 14:11 Completed build in 12m 34s on Mon, 29 Oct, 03:11 PM Test Summary: 38170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29825

  5. TYPO3com voted on patch set 2 V +1 10/29/18, 14:16 Completed build in 12m 37s on Mon, 29 Oct, 03:16 PM Test Summary: 38170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29826

  6. Andreas Kienast updated the commit message in patch set 3 10/29/18, 14:16

  7. Susi Moog voted on patch set 3 V +1 10/29/18, 14:22

  8. TYPO3com voted on patch set 3 V +1 10/29/18, 14:27 Completed build in 10m 39s on Mon, 29 Oct, 03:27 PM Test Summary: 38170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29828

  9. Susi Moog voted on patch set 3 CR +1 10/29/18, 15:03

  10. Benni Mack voted on patch set 3 V +2 CR +2 10/29/18, 15:15

  11. Benni Mack merged patch set 4 10/29/18, 15:15