Review main Merged

58787[BUGFIX] Correctly create schema diff for renamed fields and indexes

Helmut Hummel CR +2 V +2 Easy +20 −6 updated 11/08/18, 21:06

Commit message

TYPO3's schema migrator has code to create drop and add fields
statements out of renamed columns detected by doctrine.

This code however is never triggered, when using a MySQL connection
with tableoptions set, because then a new TableDiff object is created,
which does not contain the renamedColumns any more.

This fix tackles the issue in various places:

1. The charset is pulled out as well of the information_schema,
so that it is set in source and target schema objects and
table options stay the same for source and target schema.

2. The newly created table differences objects receive
the detected renamed columns and idexes.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2