Review main Merged

58859[BUGFIX] Include DB queries with free mode records

Benni Mack CR +2 V +2 Normal +83 −36 updated 11/08/18, 16:41

Commit message

With the new site handling, the overlayType for fetching
records in the frontend context is always set to
OVERLAYS_ON_WITH_FLOATING, which resolves to
the previous TypoScript settings:
- config.sys_language_overlay = 1
- styles.content.get.select.includeRecordsWithoutDefaultTranslation = 1

However, the place where "includeRecordsWithoutDefaultTranslation"
is evaluated does not check for the actual
Language Aspect of the Context API, which makes
it impossible to fetch records without "l10n_parent"
= (free mode), except for setting this option
explicitly on each TypoScript "select." query.

The patch moves the functionality into a separate method,
which allows to better unit test all options.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2