58923[FEATURE] Add properties default values in class schema
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Alexander Schnitzler +1
- Mona Muzaffar +1
-
Verified V +2
- Anja Leichsenring +2
- Alexander Schnitzler +1
- Mona Muzaffar +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/core/Documentation/Changelog/master/Feature-86964-AllowGettingClassPropertyDefaultValue.rstnew+27 −0
- typo3/sysext/extbase/Classes/Reflection/ClassSchema.php+13 −10
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyClassWithAllTypesOfProperties.php2+2 −0
- typo3/sysext/extbase/Tests/Unit/Reflection/ClassSchemaTest.php+12 −0
Review log 1925
-
Romain Canon uploaded patch set 1 11/21/18, 13:46
-
TYPO3com voted on patch set 1 V +1 11/21/18, 13:56 Completed build in 09m 45s on Wed, 21 Nov, 02:56 PM Test Summary: 48488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30223
-
Mathias Brodala commented on patch set 1 11/21/18, 13:58
I think this is actually a feature, even if a small one. Either case an RST should be added to let people know about this change.DummyClassWithAllTypesOfProperties.php:25I'd recommend leaving this property unchanged and adding an additional $publicPropertyWithDefaultValue or similar. -
Mathias Brodala commented on patch set 1 11/21/18, 13:59
This should still be "master", v10 has not been branched yet. -
Romain Canon commented on patch set 1 11/21/18, 14:03
Reply
Ok that's what I thought first, but it seemed overkill to me. Preparing the RST file right now.Reply
:not-existing-thumbs-up-emoji:DummyClassWithAllTypesOfProperties.php:25ReplyAdding a new property breaks the test: `\TYPO3\CMS\Extbase\Tests\Unit\Reflection\ClassSchemaTest::classSchemaGetProperties`; should I still add a new property and change this test as well? -
Romain Canon uploaded patch set 2 11/21/18, 14:14
-
Romain Canon updated the commit message in patch set 3 11/21/18, 14:15
-
TYPO3com voted on patch set 2 V -1 11/21/18, 14:28 Completed build in 13m 25s on Wed, 21 Nov, 03:28 PM Test Summary: 48488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30224
-
TYPO3com voted on patch set 3 V -1 11/21/18, 14:29 Completed build in 13m 45s on Wed, 21 Nov, 03:29 PM Test Summary: 48488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30225
-
Mathias Brodala commented on patch set 4 11/21/18, 14:37
Published edit on patch set 3. -
TYPO3com voted on patch set 4 V +1 11/21/18, 14:48 Completed build in 10m 45s on Wed, 21 Nov, 03:48 PM Test Summary: 48488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30226
-
Mathias Brodala voted on patch set 4 CR +1 11/21/18, 14:48
-
Wouter Wolters commented on patch set 4 CR -1 11/21/18, 17:45
we are not branched of yet, 9.5 should not be in the releases line -
Mathias Brodala updated the commit message in patch set 5 11/22/18, 08:14
-
Mathias Brodala voted on patch set 5 CR +1 11/22/18, 08:14
-
Mathias Brodala commented on patch set 5 11/22/18, 08:14
> we are not branched of yet, 9.5 should not be in the releases line Yup, missed that. -
TYPO3com voted on patch set 5 V +1 11/22/18, 08:27 Completed build in 13m 07s on Thu, 22 Nov, 09:27 AM Test Summary: 48488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30241
-
Alexander Schnitzler voted on patch set 5 CR +1 11/29/18, 13:38
-
Alexander Schnitzler commented on patch set 5 V -1 12/22/18, 17:58
Meanwhile, master means TYPO3 10 and the rest file needs to be moved accordingy. -
Alexander Schnitzler uploaded patch set 6 01/08/19, 10:10
-
Alexander Schnitzler voted on patch set 6 V +1 CR +1 01/08/19, 10:10
-
TYPO3com voted on patch set 6 V +1 01/08/19, 10:19 Completed build in 09m 21s on Tue, 8 Jan, 11:19 AM Test Summary: 47345 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31330
-
Mona Muzaffar voted on patch set 6 V +1 CR +1 01/11/19, 16:19
-
Anja Leichsenring voted on patch set 6 V +2 CR +2 01/11/19, 16:20
-
Anja Leichsenring merged patch set 7 01/11/19, 16:20