Review main Merged

58923[FEATURE] Add properties default values in class schema

Romain Canon CR +2 V +2 Normal +54 −10 updated 01/11/19, 16:20

Commit message

Allows accessing the default values of a class property, without having
to use the reflection everytime it is needed.

The default value can be accessed with the key `defaultValue` in the
property schema.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Alexander Schnitzler +1
    • Mona Muzaffar +1
  • Verified V +2
    • Anja Leichsenring +2
    • Alexander Schnitzler +1
    • Mona Muzaffar +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1925

  1. Romain Canon uploaded patch set 1 11/21/18, 13:46

  2. TYPO3com voted on patch set 1 V +1 11/21/18, 13:56 Completed build in 09m 45s on Wed, 21 Nov, 02:56 PM Test Summary: 48488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30223

  3. Mathias Brodala commented on patch set 1 11/21/18, 13:58

    I think this is actually a feature, even if a small one. Either case an RST should be added to let people know about this change.

    DummyClassWithAllTypesOfProperties.php:25

    I'd recommend leaving this property unchanged and adding an additional $publicPropertyWithDefaultValue or similar.
  4. Mathias Brodala commented on patch set 1 11/21/18, 13:59

    This should still be "master", v10 has not been branched yet.
  5. Romain Canon commented on patch set 1 11/21/18, 14:03

    Reply

    Ok that's what I thought first, but it seemed overkill to me. Preparing the RST file right now.

    Reply

    :not-existing-thumbs-up-emoji:

    DummyClassWithAllTypesOfProperties.php:25 Reply

    Adding a new property breaks the test: `\TYPO3\CMS\Extbase\Tests\Unit\Reflection\ClassSchemaTest::classSchemaGetProperties`; should I still add a new property and change this test as well?
  6. Romain Canon uploaded patch set 2 11/21/18, 14:14

  7. Romain Canon updated the commit message in patch set 3 11/21/18, 14:15

  8. TYPO3com voted on patch set 2 V -1 11/21/18, 14:28 Completed build in 13m 25s on Wed, 21 Nov, 03:28 PM Test Summary: 48488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30224

  9. TYPO3com voted on patch set 3 V -1 11/21/18, 14:29 Completed build in 13m 45s on Wed, 21 Nov, 03:29 PM Test Summary: 48488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30225

  10. Mathias Brodala commented on patch set 4 11/21/18, 14:37

    Published edit on patch set 3.
  11. TYPO3com voted on patch set 4 V +1 11/21/18, 14:48 Completed build in 10m 45s on Wed, 21 Nov, 03:48 PM Test Summary: 48488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30226

  12. Mathias Brodala voted on patch set 4 CR +1 11/21/18, 14:48

  13. Wouter Wolters commented on patch set 4 CR -1 11/21/18, 17:45

    we are not branched of yet, 9.5 should not be in the releases line
  14. Mathias Brodala updated the commit message in patch set 5 11/22/18, 08:14

  15. Mathias Brodala voted on patch set 5 CR +1 11/22/18, 08:14

  16. Mathias Brodala commented on patch set 5 11/22/18, 08:14

    > we are not branched of yet, 9.5 should not be in the releases line Yup, missed that.
  17. TYPO3com voted on patch set 5 V +1 11/22/18, 08:27 Completed build in 13m 07s on Thu, 22 Nov, 09:27 AM Test Summary: 48488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30241

  18. Alexander Schnitzler voted on patch set 5 CR +1 11/29/18, 13:38

  19. Alexander Schnitzler commented on patch set 5 V -1 12/22/18, 17:58

    Meanwhile, master means TYPO3 10 and the rest file needs to be moved accordingy.
  20. Alexander Schnitzler uploaded patch set 6 01/08/19, 10:10

  21. Alexander Schnitzler voted on patch set 6 V +1 CR +1 01/08/19, 10:10

  22. TYPO3com voted on patch set 6 V +1 01/08/19, 10:19 Completed build in 09m 21s on Tue, 8 Jan, 11:19 AM Test Summary: 47345 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31330

  23. Mona Muzaffar voted on patch set 6 V +1 CR +1 01/11/19, 16:19

  24. Anja Leichsenring voted on patch set 6 V +2 CR +2 01/11/19, 16:20

  25. Anja Leichsenring merged patch set 7 01/11/19, 16:20