58931[BUGFIX] Add allowLanguageSynchronization to `copyright` field
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 1115
-
TYPO3com uploaded patch set 1 11/22/18, 12:31
-
TYPO3com voted on patch set 1 V +1 11/22/18, 12:43 Completed build in 11m 24s on Thu, 22 Nov, 01:43 PM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30245
-
Jörg Bösche voted on patch set 1 CR +1 12/06/18, 12:49
-
Josef Glatz commented on patch set 1 CR -1 12/06/18, 13:52
Commit Message needs to be adopted -
Guido Schmechel commented on patch set 1 12/08/18, 08:52
I would see that as a bugfix. What do you all mean? -
Oli Bartsch updated the commit message in patch set 2 11/09/19, 17:09
-
Oli Bartsch commented on patch set 2 V -1 11/09/19, 17:13
AFAICS this would break installations with custom values in the localized copyright field as the default is always "Value of default language" even if there's already a value in the field. Or do I misse something here? -
TYPO3com voted on patch set 2 V +1 11/09/19, 17:18 Completed build in 08m 14s on Sat, 9 Nov, 05:18 PM Test Summary: 48292 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38208
-
Benni Mack commented on patch set 2 04/30/20, 07:50
Hey Oli, can you quickly test and verify the behaviour you described? I believe this is automatically checked when editing a record. nevertheless we'd need an upgrade wizard to synchronize this.sys_file_metadata.php:263UnresolvedI suggest to drop this property if it is empty -
Jörg Bösche commented on patch set 3 08/25/20, 09:18
Published edit on patch set 2. -
TYPO3com voted on patch set 3 V +1 08/25/20, 09:29 Completed build in 10m 58s on Tue, 25 Aug, 09:29 AM Test Summary: 73074 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4937
-
Oli Bartsch commented on patch set 3 11/04/21, 14:45
> Patch Set 2: > > (1 comment) > > Hey Oli, can you quickly test and verify the behaviour you described? I believe this is automatically checked when editing a record. nevertheless we'd need an upgrade wizard to synchronize this. Just verified my initial comment. Applying the patch "overrides" any custom value in a L>0 record, because "Value of default language" is used as the default automatically. Additionally, when saving such localization, the custom value is completely removed from the record. This patch requires an upgrade wizard. -
Christian Kuhn commented on patch set 3 11/09/21, 20:28
Hey. I hope it's ok that I take the decision here to abandon this change for now: It is pending since 2018 and nothing happened without cosmetical changes. Imho, allowLanguageSynchronization needs a bigger review on casual fields and a broader decision if we want that on "simple" fields: core v11 added this for some tt_content relations (FAL) by default, but not for casual input fields, since it makes a lot of sense for these. This change as standalone, encapsulated thing for "copyright" is a different case and should be decided on in a broader view. -
Christian Kuhn abandoned the change 11/09/21, 20:28
-
Christian Kuhn commented on patch set 3 11/09/21, 20:29
note: if this is *really* beneficial for customer projects, it can of course be set on a project-by-project basis by adding this flag to tca - there is no hard pressure to do this in core now.