Review main Merged

59083[TASK] Avoid slow array functions in loops

Andreas Kienast CR +2 V +2 Hard +254 −266 updated 09/25/19, 16:37

Commit message

This patch moves some array functions used in loops (array_merge,
array_replace) out of their calling loop for performance reasons, where
applicable.

This this achieved by calling the functions via array unpacking ("splat
operator").

See for further reading:
https://github.com/kalessil/phpinspectionsea/blob/master/docs/performance.md#slow-array-function-used-in-loop

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 52

Show 32 more files