Review main Merged

59117[BUGFIX] Avoid frameborder attribute if no doctype is set

Georg Ringer CR +2 V +2 Easy +2 −4 updated 12/22/18, 12:47

Commit message

The YouTube and Vimeo renderer must also check if the doctype is not set as html5 is
the default value.

Review

  • Code review CR +2
    • Benni Mack +2
    • Josef Glatz +1
    • Tomas Norre Mikkelsen +1
    • Jörg Bösche +1
  • Verified V +2
    • Benni Mack +2
    • Josef Glatz +1
    • Guido Schmechel +1
    • Riccardo De Contardi +1
    • TYPO3com +1 CI

Files 2

Review log 910

  1. Georg Ringer uploaded patch set 1 12/11/18, 12:57

  2. TYPO3com voted on patch set 1 V +1 12/11/18, 13:09 Completed build in 12m 27s on Tue, 11 Dec, 02:09 PM Test Summary: 48756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30601

  3. Tomas Norre Mikkelsen commented on patch set 1 CR +1 12/11/18, 19:58

    VimeoRenderer.php:194

    For readability i prefer multiple lines, but I'm not 100% what the CGL says on this. The line is pretty long.
  4. Josef Glatz voted on patch set 1 V +1 CR +1 12/11/18, 20:58

  5. Riccardo De Contardi voted on patch set 1 V +1 12/15/18, 16:15

  6. Guido Schmechel voted on patch set 1 V +1 12/16/18, 12:20

  7. Jörg Bösche voted on patch set 1 CR +1 12/18/18, 07:55

  8. Benni Mack voted on patch set 1 V +2 CR +2 12/22/18, 12:09

  9. Benni Mack merged patch set 2 12/22/18, 12:09

  10. Georg Ringer commented on patch set 2 12/22/18, 12:47

    Cherry Picked This patchset was cherry picked to branch 9.5 as commit 360c4dd189fe8d43e3374c045473867b3343ca04