Review main Merged

59166[BUGFIX] Mark form as changed after using the image cropper

Andreas Kienast CR +2 V +2 Easy +3 −1 updated 02/19/19, 16:20

Commit message

The image cropper now marks the form as "changed" after saving new
cropping information.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Josef Glatz +1
    • Guido Schmechel +1
  • Verified V +2
    • Georg Ringer +2
    • Josef Glatz +1
    • Guido Schmechel +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 911

  1. Andreas Kienast uploaded patch set 1 12/16/18, 11:24

  2. Andreas Kienast updated the commit message in patch set 2 12/16/18, 11:26

  3. TYPO3com voted on patch set 1 V +1 12/16/18, 11:38 Completed build in 13m 16s on Sun, 16 Dec, 12:38 PM Test Summary: 48760 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30734

  4. TYPO3com voted on patch set 2 V +1 12/16/18, 11:39 Completed build in 12m 54s on Sun, 16 Dec, 12:39 PM Test Summary: 48760 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30735

  5. Josef Glatz commented on patch set 2 CR +1 12/16/18, 12:01

    Thanks Mr TypeScript! I will verify a little bit later
  6. Guido Schmechel voted on patch set 2 V +1 CR +1 12/16/18, 12:06

  7. Josef Glatz commented on patch set 2 V +1 12/16/18, 12:24

    works
  8. Georg Ringer voted on patch set 2 V +2 CR +2 12/17/18, 09:25

  9. Georg Ringer merged patch set 3 12/17/18, 09:25

  10. Andreas Kienast commented on patch set 3 12/17/18, 09:27

    Cherry Picked This patchset was cherry picked to branch 9.5 as commit 2802c19243f4318c1f797706951b697609a2ae18
  11. Stephan Großberndt commented on patch set 3 02/19/19, 16:20

    The cherry-picks for 9.5 and 8.7 have a different change-id. They have been merged and can be found here: https://review.typo3.org/#/c/Packages/TYPO3.CMS/+/59177/ https://review.typo3.org/#/c/Packages/TYPO3.CMS/+/59178/