Review main Merged

59182[BUGFIX] Catch error in database Upgrade Wizard

Nicole Hummel CR +2 V +2 Easy +9 −3 updated 03/25/20, 05:55

Commit message

If an extension provides wrong SQL in ext_tables.sql, the upgrade
wizard is skipped completely. This patch catches the current
exception and outputs the error that needs to be resolved manually.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Markus Klein +1
    • Benni Mack +1
  • Verified V +2 Done
    • Susi Moog +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1518

  1. Nicole Hummel uploaded patch set 1 12/17/18, 13:49

  2. TYPO3com voted on patch set 1 V +1 12/17/18, 14:00 Completed build in 10m 53s on Mon, 17 Dec, 03:00 PM Test Summary: 48760 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30768

  3. Nicole Hummel updated the commit message in patch set 2 12/17/18, 15:05

  4. TYPO3com voted on patch set 2 V +1 12/17/18, 15:19 Completed build in 13m 22s on Mon, 17 Dec, 04:19 PM Test Summary: 48760 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30769

  5. Markus Klein commented on patch set 2 12/17/18, 19:12

    where is this output generated? the exception is not passed on.
  6. Nicole Hummel commented on patch set 2 12/18/18, 10:14

    Reply

    The output is shown as flash message above the upgrade wizard list. It is not part of the patch nor the wizard itself. But seeing this message is better than seeing a fatal error I think.
  7. Markus Klein commented on patch set 2 03/07/19, 21:04

    Reply Unresolved

    Seems like I'm blind. Can you please help me and point me to the place where the error is converted to the flash message? I'd like to understand this by reading the code. Thanks.
  8. Nicole Hummel commented on patch set 2 03/08/19, 10:53

    @Markus: As far as I can remember there is no error output in master/9.5 for upgrade errors yet. It is not part of this patch to introduce one. But there is some handling in 8.7. I don't know if this patch should only be taggle 8.7 branch or all. Feel free to adjust.
  9. Markus Klein commented on patch set 2 03/08/19, 11:05

    Thanks Nicole. Now I see what you mean. This takes the same spot as https://review.typo3.org/c/Packages/TYPO3.CMS/+/59183 which still needs a forward-port for master. Will put that on my list as well
  10. Susi Moog commented on patch set 2 10/25/19, 19:44

    Hey Markus, is this issue still on your list? Is there an error handling in master / 9.5 yet or is this basically blocked because we'd need to implement that first?
  11. Markus Klein commented on patch set 2 10/25/19, 19:49

    > Patch Set 2: > > Hey Markus, is this issue still on your list? Is there an error handling in master / 9.5 yet or is this basically blocked because we'd need to implement that first? AFAIK there is still no way to handle feedback for the user in v9+. So I guess this one is blocked.
  12. Benni Mack uploaded patch set 3 03/23/20, 14:36

  13. Benni Mack voted on patch set 3 CR +1 03/23/20, 14:36

  14. TYPO3com voted on patch set 3 V +1 03/23/20, 14:48 Completed build in 11m 47s on Mon, 23 Mar, 02:48 PM Test Summary: 72225 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1626

  15. Markus Klein voted on patch set 3 CR +1 03/23/20, 14:48

  16. Benni Mack voted on patch set 3 V +1 03/24/20, 16:45

  17. Susi Moog voted on patch set 3 V +2 CR +2 03/25/20, 05:54

  18. Susi Moog merged patch set 4 03/25/20, 05:55