Review main Merged Breaking

59190[!!!][TASK] Remove deprecated code from charset converter

Benni Mack CR +2 V +2 Hard +73 −355 updated 12/18/18, 17:34

Commit message

The CharsetConverter class can now be reduced into smaller parts due
to deprecation removals.

Properties now marked as internal:
- parsedCharsets
- noCharByteVal
- toASCII
- twoByteSets
- eucBasedSets

Removed properties:
- synonyms

Removed public methods:
- parse_charset
- convArray
- utf8_to_entities
- entities_to_utf8
- crop
- convCaseFirst
- utf8_char2byte_pos

Removed arguments from public methods:
- 4th argument $useEntityForNoChar of conv

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 6