Review main Merged Breaking

59197[!!!][TASK] Remove deprecated code from core Crypto/PasswordHashing

Christian Kuhn CR +2 V +2 Nightmare +204 −2437 updated 12/19/18, 07:45

Commit message

Removed classes:
TYPO3\CMS\Core\Crypto\PasswordHashing\AbstractComposedSalt

Removed interfaces:
TYPO3\CMS\Core\Crypto\PasswordHashing\ComposedPasswordHashInterface
TYPO3\CMS\Core\Crypto\PasswordHashing\ExtensionManagerConfigurationUtility
TYPO3\CMS\Core\Crypto\PasswordHashing\SaltedPasswordService
TYPO3\CMS\Core\Crypto\PasswordHashing\SaltedPasswordsUtility

Removed class aliases:
TYPO3\CMS\Saltedpasswords\Salt\AbstractSalt
TYPO3\CMS\Saltedpasswords\Salt\AbstractComposedSalt
TYPO3\CMS\Saltedpasswords\Salt\Argon2iSalt
TYPO3\CMS\Saltedpasswords\Salt\BcryptSalt
TYPO3\CMS\Saltedpasswords\Salt\BlowfishSalt
TYPO3\CMS\Saltedpasswords\Salt\ComposedSaltInterface
TYPO3\CMS\Saltedpasswords\Salt\Md5Salt
TYPO3\CMS\Saltedpasswords\Salt\SaltFactory
TYPO3\CMS\Saltedpasswords\Salt\SaltInterface
TYPO3\CMS\Saltedpasswords\Salt\Pbkdf2Salt
TYPO3\CMS\Saltedpasswords\Salt\PhpassSalt
TYPO3\CMS\Saltedpasswords\SaltedPasswordsService
TYPO3\CMS\Saltedpasswords\Utility\ExensionManagerConfigurationUtility
TYPO3\CMS\Saltedpasswords\Utility\SaltedPasswordsUtility

Removed methods:
TYPO3\CMS\Core\Crypto\PasswordHashing\Argon2iPasswordHash->getOptions()
TYPO3\CMS\Core\Crypto\PasswordHashing\Argon2iPasswordHash->setOptions()
TYPO3\CMS\Core\Crypto\PasswordHashing\BcryptPasswordHash->getOptions()
TYPO3\CMS\Core\Crypto\PasswordHashing\BcryptPasswordHash->setOptions()
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->getHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->getMaxHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->getMinHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->getSaltLength()
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->getSetting()
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->setHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->setMaxHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->setMinHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\Md5PasswordHash->getSetting()
TYPO3\CMS\Core\Crypto\PasswordHashing\Md5PasswordHash->getSaltLength()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->getHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->getMaxHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->getMinHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->getSaltLength()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->getSetting()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->setHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->setMaxHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->setMinHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->getHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->getMaxHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->getMinHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->getSaltLength()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->getSetting()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->setHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->setMaxHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->setMinHashCount()

Protected methods:
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishPasswordHash->isValidSalt()
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishPasswordHash->base64Encode()
TYPO3\CMS\Core\Crypto\PasswordHashing\Md5PasswordHash->isValidSalt()
TYPO3\CMS\Core\Crypto\PasswordHashing\Md5PasswordHash->base64Encode()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->isValidSalt()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->base64Encode()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->base64Decode()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->isValidSalt()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->base64Encode()

Removed static methods:
TYPO3\CMS\Core\Crypto\PasswordHashing\PasswordHashFactory::determineSaltingHashingMethod()
TYPO3\CMS\Core\Crypto\PasswordHashing\PasswordHashFactory::getSaltingInstance()
TYPO3\CMS\Core\Crypto\PasswordHashing\PasswordHashFactory::setPreferredHashingMethod()

Second method argument dropped:
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishPasswordHash->getHashedPassword()
TYPO3\CMS\Core\Crypto\PasswordHashing\Md5PasswordHash->getHashedPassword()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->getHashedPassword()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->getHashedPassword()

Ignored options:
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['ext/saltedpasswords']['saltMethods']

Dropped constants:
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishPasswordHash::ITOA64
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishPasswordHash::HASH_COUNT
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishPasswordHash::MAX_HASH_COUNT
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishPasswordHash::MIN_HASH_COUNT
TYPO3\CMS\Core\Crypto\PasswordHashing\Md5PasswordHash::ITOA64
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash::ITOA64
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash::HASH_COUNT
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash::MAX_HASH_COUNT
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash::MIN_HASH_COUNT
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash::ITOA64
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash::HASH_COUNT
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash::MAX_HASH_COUNT
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash::MIN_HASH_COUNT

Removed language file aliases:
EXT:saltedpasswords/Resources/Private/Language/locallang.xlf
EXT:saltedpasswords/Resources/Private/Language/locallang_em.xlf

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 35

Show 15 more files