Review main Merged Breaking

59226[!!!][TASK] Remove deprecated code related to TSFE

Benni Mack CR +2 V +2 Nightmare +217 −3591 updated 12/20/18, 08:15

Commit message

The following code related to TSFE has been removed:

PHP classes:
* TYPO3\CMS\Core\PageTitle\AltPageTitleProvider
* TYPO3\CMS\Frontend\Page\ExternalPageUrlHandler
* TYPO3\CMS\Frontend\Page\PageGenerator
* TYPO3\CMS\Frontend\Page\EidUtility

PHP interfaces:
* TYPO3\CMS\Frontend\Http\UrlHandlerInterface

Methods that have been marked as protected
* tempPageCacheContent()
* realPageCacheContent()
* setPageCacheContent()
* clearPageCacheContent_pidList()
* setSysLastChanged()
* contentStrReplace()

Dropped TSFE methods
* mergingWithGetVars()
* connectToDB()
* initFEuser()
* checkAlternativeIdMethods()
* initializeBackendUser()
* getPageShortcut()
* pageUnavailableAndExit()
* pageNotFoundAndExit()
* checkPageUnavailableHandler()
* pageUnavailableHandler()
* pageNotFoundHandler()
* pageErrorHandler()
* makeCacheHash()
* initTemplate()
* handleDataSubmission()
* initializeRedirectUrlHandlers()
* redirectToExternalUrl()
* checkPageForMountpointRedirect()
* checkPageForShortcutRedirect()
* redirectToCurrentPage()
* processOutput()
* sendCacheHeaders()
* sendHttpHeadersDirectly()
* storeSessionData()
* previewInfo()
* hook_eofe()
* addTempContentHttpHeaders()
* setCSS()
* getUniqueId()
* readLLfile()
* getLLL()
* initLLvars()
* convPOSTCharset()
* convertCharsetRecursivelyToUtf8()
* domainNameMatchesCurrentRequest()
* getDomainDataForPid()
* getDomainNameForPid()

Dropped TSFE properties
* activeUrlHandlers
* page_cache_reg1
* siteScript
* loginUser
* gr_list
* beUserLogin
* workspacePreview
* ADMCMD_preview_BEUSER_uid
* showHiddenPage
* showHiddenRecords
* debug
* MP_defaults
* sys_language_uid
* sys_language_mode
* sys_language_content
* sys_language_contentOL
* altPageTitle
* lang

TSFE Properties now marked as protected
* loginAllowedInBranch
* loginAllowedInBranch_mode
* cacheTimeOutDefault
* cacheContentFlag
* cacheExpires
* isClientCachable
* no_cacheBeforePageGen
* tempContent
* pagesTSconfig
* pageCacheTags
* uniqueCounter
* uniqueString
* pageAccessFailureHistory

TSFE Method Signature changes
* calculateLinkVars now 1st parameter is required
* preparePageContentGeneration now 1st parameter is required
4th Parameter of TSFE->__construct() now unused

Removed TypoScript
* config.typolinkCheckRootline
* config.titleTagFunction
* config.USERUID_substToken
* config.USERNAME_substToken

Hooks
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['tslib_fe-PostProc']

Database fields:
* index_phash.data_page_reg1

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 28

Show 8 more files