Review main Merged Breaking

59231[!!!][TASK] Drop support for deprecated cache usage in ext_localconf

Benjamin Franzke CR +2 V +2 Normal +75 −53 updated 01/15/19, 11:49

Commit message

The initialization of the CacheManager has a design problem:

The *CacheManager* is used to create the core_cache. That core_cache
is used to read the (possibly) cached *CacheManager* configuration
(from ext_localconf.php), which is then used to (re)configure the
already-being-used *CacheManager* after ext_localconf.php has been
loaded. That means an extension can create a cache while it has
not been configured by a second extension. That behaviour was
deprecated in v9 and can therefore be dropped now.

We now create the core cache (and because of requirements
in core currently also the 'assets' cache) during early bootstrap
(independently from the CacheManager) and inject these early caches
into the CacheManager instance later on. The CacheManager instance is now
created during late bootstrap.
Looking forward to a Dependency Injection (DI) container, this change will
allow to move the CacheManager creation from bootstrap code into the DI
service providers (which will allow the CacheManager to be instantiated
on demand)

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 3