Review main Merged

59331[TASK] Avoid runtime reflection calls in ObjectAccess

Alexander Schnitzler CR +2 V +2 Hard +464 −220 updated 06/29/20, 20:19

Commit message

ObjectAccess had two kinds of runtime reflection calls:

1) To gather data about object properties and methods
2) To make non public properties accessible

The first one is tackled by using class schema instances
and by using the property accessor of symfony/property-access.

The latter is tackled by deprecating all method arguments
that trigger reflection to make properties accessible. In
the future, gettable/settable properties need to be either
public or have a getter (get*/has*/is*) or setter.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 15