Review main Merged Breaking

59392[!!!][TASK] Drop PATH_thisScript constant

Christian Kuhn CR +2 V +2 Hard +260 −82 updated 01/11/19, 07:37

Commit message

The patch removes the definition of constant PATH_thisScript.

* The main change in SystemEnvironmentBuilder splits method
definePaths() into two parts calculateScriptPath() and
calculateRootPath() since definePaths() formerly communicated
the script path using the PATH_thisScript constant to method
initializeEnvironment(), which has to fall now. Note
initializeEnvironment() is now protected, which is ok since
that usage was only internally for the testing framework which
is resolved now, too.

* A raise of the testing framework from 5.0.1 to 5.0.2 is needed.
It also defined that constant and triggered some different code
paths with this in SystemEnvironmentBuilder.
composer require --dev typo3/testing-framework ~5.0.2

* With the changes in SystemEnvironmentBuilder,
Environment::getCurrentScript() now returns '.../bin/phpunit' and
not '.../typo3/index.php' in unit tests, which is more correct. This
however has the side effect that various path related unit tests
need an adaption to properly set up the environment as needed.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 13