Review main Merged

59422[TASK] Improve ClassSchema methods api

Alexander Schnitzler CR +2 V +2 Expert +948 −382 updated 02/01/19, 15:44

Commit message

This patch introduces a new Method class to have an
easier and more stable api to get information about class
methods from ClassSchema objects.

The reflection data fetched and stored by/in the ClassSchema
objects is no longer publicly available as an array. Instead,
Method objects are returned for the following calls:

- getMethod
- getMethods
- getInjectMethods

Also it removes the following method:

- getConstructorArguments

The following constants are marked as private:

- ClassSchema::MODELTYPE_ENTITY
- ClassSchema::MODELTYPE_VALUEOBJECT

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 16