Review main Abandoned

59451[BUGFIX] Move deleted inline records along with their parents

Alexander Stehlik CR 0 V 0 Easy +45 −0 updated 02/09/24, 13:55

Commit message

The data handler now also moves IRRE child records to the
new page when they are deleted.

The relation handler is configured to return deleted records
and the delete check for the permission checking is
temporarily disabled.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 4

Review log 2026

Show 1 earlier messages
  1. Alexander Stehlik uploaded patch set 1 01/15/19, 18:57

  1. TYPO3com voted on patch set 1 V -1 01/15/19, 19:09 Completed build in 12m 10s on Tue, 15 Jan, 08:09 PM Test Summary: 47470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31537

  2. Alexander Stehlik updated the commit message in patch set 2 01/15/19, 19:26

  3. TYPO3com voted on patch set 2 V +1 01/15/19, 19:38 Completed build in 12m 26s on Tue, 15 Jan, 08:38 PM Test Summary: 47541 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31538

  4. Markus Klein commented on patch set 2 CR -1 08/01/19, 09:31

    IMO the assumption is wrong. IRRE children not necessarily live on the same page as the parent record. It depends on the usecase whether something must be moved or not.
  5. Alexander Stehlik commented on patch set 2 08/02/19, 23:00

    Hi Markus. Thank you for your feedback. I'm not sure if I get your point. The elements are currently moved. This is not changed by this patch. The only difference is, that I also move deleted elements. Would be great if you could give me a hint how to adjust the patch to fulfill your needs.
  6. Markus Klein commented on patch set 2 CR 0 08/05/19, 07:23

    > I'm not sure if I get your point. The elements are currently moved. This is not changed by this patch. The only difference is, that I also move deleted elements. They are moved?? Okay, I never noticed that before, so then we actually have another much more severe bug there. IMO the system can not decide whether IRRE-children have to moved to another pid or not, this depends soley on the use case. So I'm fine with this change, so we get the current behaviour consistent
  7. Alexander Stehlik commented on patch set 2 08/05/19, 18:56

    > They are moved?? Okay, I never noticed that before, so then we actually have another much more severe bug there. > IMO the system can not decide whether IRRE-children have to moved to another pid or not, this depends soley on the use case. There is a setting do prevent this for quite some time (I checked back to 6.2), so this should not be a problem. See: https://docs.typo3.org/m/typo3/reference-tca/6.2/en-us/Reference/Columns/Inline/Index.html#behaviour
  8. Alexander Stehlik uploaded patch set 3 10/27/19, 10:46

  9. TYPO3com voted on patch set 3 V -1 10/27/19, 11:00 Completed build in 10m 47s on Sun, 27 Oct, 11:00 AM Test Summary: 48070 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37803

  10. Alexander Stehlik uploaded patch set 4 10/27/19, 21:38

  11. TYPO3com voted on patch set 4 V +1 10/27/19, 21:48 Completed build in 10m 35s on Sun, 27 Oct, 09:48 PM Test Summary: 48070 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37810

  12. Benni Mack wrote 04/06/20, 09:42

    Topic set to DataHandler
  13. Benni Mack updated the commit message in patch set 5 05/25/20, 18:46

  14. Oliver Hader commented on patch set 5 06/14/21, 11:43

    Isn't that a general topic (not only related to `inline`)? For instance: * having a content element with one localization * delete that localized record * now move existing content element (default language) to different page * what happens to deleted localized record?
  15. Alexander Stehlik commented on patch set 5 06/14/21, 20:03

    Reply Unresolved

    That is a valid point. The related method in the DataHandler moveL10nOverlayRecords() currently filters out deleted records. This restriction should probably removed as well. Unfortunately I can not assess the consequence of such a change to the DataHandler. I you (or someone else with deeper knowledge of the DataHandler) think it's the way to go I'll gladly add it to the patch.
  16. Benni Mack updated the commit message in patch set 6 11/18/21, 10:38

  17. Benni Mack wrote 11/29/21, 10:17

    Change destination moved from master to main
  18. Benni Mack updated the commit message in patch set 7 11/29/21, 14:08

  19. Benni Mack rebased onto patch set 8 12/23/21, 10:07

  20. core-ci voted on patch set 8 V -1 12/23/21, 10:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21416

  21. Benni Mack updated the commit message in patch set 9 V -1 05/03/23, 09:13

  22. core-ci voted on patch set 9 V -1 05/03/23, 09:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41381

  23. Simon Schaufelberger commented on patch set 9 08/24/23, 16:19

    Hi Alexander, would you please rebase your patch and make it work?
  24. Christian Kuhn commented on patch set 9 02/09/24, 13:51

    Hey. I have a rather strong opinion in this area and will thus decide on this patch now to have a final answer if nobody else comes up with a rather strong opposite opinion, plus according patches: deleted=1 means the record is gone. that simple. the only exception is 'undelete' in ext:recycler. mid-term we should actually free tables from deleted=1 and move affected records to some other table (a "wastebin" table that gathers them all), together with a transaction-id for potential rollback. Olly is correct, when we for instance delete=1 a localization, and then move the default language record, then the deleted=1 localization is *of course* NOT moved along, anymore: deleted=1 means the record is "dead" and no longer handled, it's lifecycle ended, and it is no longer part of system integrity as such. With this view in mind, it's obvious that we'll not merge this patch.
  25. Christian Kuhn abandoned the change 02/09/24, 13:55