Review main Merged

59465[BUGFIX] Fix duplicate rendering of 'pages' id-attribute

Moritz Ngo CR +2 V +2 Easy +11 −5 updated 01/17/19, 14:08

Commit message

When translations and (sub-)pages are present at the same time the
'page' id-attribute will be rendered twice.
This ensures that translations and (sub-)pages are independently
collapsible.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Moritz Ngo uploaded patch set 1 01/16/19, 20:09

  2. TYPO3com voted on patch set 1 V +1 01/16/19, 20:21 Completed build in 12m 07s on Wed, 16 Jan, 09:21 PM Test Summary: 47042 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31559

  3. Helmut Hummel commented on patch set 1 V +1 CR +1 01/16/19, 20:26

    DatabaseRecordList.php:1102

    I like the nostalgic flavor of this identifier :-D
  4. Alexander Stehlik commented on patch set 1 V +1 CR +1 01/16/19, 22:07

    DatabaseRecordList.php:1102 Reply

    Hehe, I suggested to use a different name (in the 9.5 patch by accident) to avoid confusion. But I also like your point of view on this :D
  5. Christian Kuhn commented on patch set 1 CR -1 01/17/19, 11:04

    DatabaseRecordList.php:1102 Reply

    no. please use a different identifier. pages_language_overlay is sort of doomed and using this here adds further confusion. i'll pick something different, rebase the patch and add a comment.
  6. Christian Kuhn uploaded patch set 2 01/17/19, 11:10

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 01/17/19, 11:13

  8. TYPO3com voted on patch set 2 V +1 01/17/19, 11:25 Completed build in 14m 44s on Thu, 17 Jan, 12:25 PM Test Summary: 47032 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31576

  9. Wouter Wolters voted on patch set 2 CR +1 01/17/19, 11:47

  10. Anja Leichsenring voted on patch set 2 V +2 CR +2 01/17/19, 14:06

  11. Anja Leichsenring merged patch set 3 01/17/19, 14:08