Review main Merged Breaking

59514[!!!][TASK] Remove view related properties from ActionController

Alexander Schnitzler CR +2 V +2 Normal +91 −128 updated 01/31/19, 06:22

Commit message

Both properties $namespacesViewObjectNamePattern and
$viewFormatToObjectNameMap of class ActionController
have been removed without replacement.

Both properties provided a functionality to set a
custom view object class during runtime. As this
contradicts the idea of having a defined state per
request by configuring concrete implementations
before runtime, these properties needed to vanish.

While there is no dependency injection with a proper
configuration available, the view object class can
still be defined via property $defaultViewObjectName.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 6