Review main Merged

59565[TASK] Reduce information disclosure of the used TYPO3 version

Josef Glatz CR +2 V +2 Easy +1 −1 updated 02/01/19, 16:07

Commit message

Reduce information disclosure of the used TYPO3 version by adding
a dynamic 4-digit year in the TYPO3_copyright_year constant.

That makes it more difficult to find out the used TYPO3 version
just by looking at the frontend source code of a website.

Review

  • Code review CR +2
    • Andreas Wolf +2
    • Georg Ringer +1
    • Fabien Udriot +1
    • Mona Muzaffar +1
    • Mathias Brodala +1
    • Oliver Klee +1
    • Stephan Großberndt +1
    • Richard Haeser +1
    • André Buchmann +1
    • Jigal van Hemert +1
  • Verified V +2
    • Andreas Wolf +2
    • Georg Ringer +1
    • Fabien Udriot +1
    • Mona Muzaffar +1
    • Richard Haeser +1
    • André Buchmann +1
    • Jigal van Hemert +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1415

  1. Josef Glatz uploaded patch set 1 01/24/19, 15:12

  2. Josef Glatz commented on patch set 1 01/24/19, 15:20

    What do you think about that patch? If there are no restrictions on "law" side, such a change could be nice to reduce the amount of information a TYPO3 instance can give you about a particular version just be looking into the source code of a website
  3. TYPO3com voted on patch set 1 V +1 01/24/19, 15:23 Completed build in 11m 48s on Thu, 24 Jan, 04:23 PM Test Summary: 46910 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31746

  4. Georg Ringer voted on patch set 1 V +1 CR +1 01/24/19, 18:09

  5. Mathias Brodala commented on patch set 1 CR +1 01/25/19, 08:26

    It also means that we can never ever forget to update this again. ;-) If it is permitted by copyright law, it's fine with me.
  6. Josef Glatz commented on patch set 1 01/25/19, 12:53

    > It also means that we can never ever forget to update this again. > ;-) > > If it is permitted by copyright law, it's fine with me. I can also limit the dynamic year only at publicly accessible areas if such a change isn't OK. In generally that would be FE head comment and the Be login mask website
  7. Richard Haeser voted on patch set 1 V +1 CR +1 01/25/19, 19:17

  8. Jigal van Hemert commented on patch set 1 V +1 CR +1 01/27/19, 07:44

    Just looked it up. Short story: neither element, the word "copyright" or the symbol, the name of the author, the year of publication, is required. Copyright is automatic and extends for natural persons a long time (mostly 50 or 70 years) after their death. We could also leave out the year completely. 21+ years looks nice, so let's keep it.
  9. Oliver Klee voted on patch set 1 CR +1 01/27/19, 15:50

  10. Stephan Großberndt voted on patch set 1 CR +1 01/27/19, 23:31

  11. Fabien Udriot voted on patch set 1 V +1 CR +1 01/28/19, 11:05

  12. Mona Muzaffar voted on patch set 1 V +1 CR +1 02/01/19, 15:40

  13. André Buchmann voted on patch set 1 V +1 CR +1 02/01/19, 15:49

  14. Andreas Wolf voted on patch set 1 V +2 CR +2 02/01/19, 16:07

  15. Andreas Wolf merged patch set 2 02/01/19, 16:07