Review main Merged

59620[BUGFIX] Raise minimum required prophecy version to 1.7.5

Benjamin Franzke CR +2 V +2 Easy +3 −1 updated 02/02/19, 10:28

Commit message

The recently introduced `object` type declarations for extbase classes
require a minimum version of prophecy 1.7.5. Previous versions trigger
the following error:
  Scalar type declaration 'object' must be unqualified

Prophecy added support for object type declarations in 1.7.4 and
for return type object declarations in 1.7.5.

Therefore we add an explicit dev dependency to prophecy in composer.json
now (previously it was transitively required as ^1.7 by phpunit 7.1).

composer require --no-update --dev phpspec/prophecy:^1.7.5
composer update --lock

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3