Review main Merged

59641[BUGFIX] Fix count for custom queries with group by statement

Stefan Froemken CR +2 V +2 Normal +146 −4 updated 11/04/20, 17:07

Commit message

When using the extbase persistence and setting a custom query
with group by statements via $query->statement($statement),
calling $query->execute()->count() did not return the right
amount of records. Instead the database backend chose the
first column of one of the returned records which resulted
in the count of a subset of grouped records.

To fix this, the database backend needs to build a count
query with a distinct statement on all fields that are
used for the grouping.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 4