Review TYPO3_4-5 Merged

5970[BUGFIX] date expects parameter 2 to be long, string given

Markus Klein CR +2 V +2 Easy +5 −3 updated 06/03/13, 20:49

Commit message

Any zero length string value is replaced with the current timestamp.
(Just like the default value for the second parameter of date/gmdate.)

Review

  • Code review CR +2
    • Georg Ringer +2
    • Simon Schaufelberger +1
  • Verified V +2
    • Georg Ringer +2
    • Simon Schaufelberger +1

Files 1

Review log 5

  1. Markus Klein commented on patch set 1 10/18/11, 16:19

  2. Simon Schaufelberger commented on patch set 1 10/18/11, 16:19

    Verified; Looks good to me, but someone else must approve
  3. Mr. Jenkins commented on patch set 1 10/18/11, 16:19

  4. Georg Ringer commented on patch set 1 V 0 10/18/11, 16:19

    by team member; Looks good to me, approved
  5. Georg Ringer merged patch set 1 10/18/11, 16:19