Review main Merged

59779[BUGFIX] Add check for string to prevent PHP warning

Peter Kraume CR +2 V +2 Easy +1 −1 updated 03/04/19, 13:54

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • Frank Nägler +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1216

  1. Peter Kraume uploaded patch set 1 02/21/19, 13:21

  2. TYPO3com voted on patch set 1 V +1 02/21/19, 13:34 Completed build in 13m 15s on Thu, 21 Feb, 02:34 PM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32328

  3. Oliver Klee commented on patch set 1 02/21/19, 15:03

    Are 9.5 and 8.7 affected as well?

    ShowImageController.php:126

    I propose to have a positive check: is_string
  4. Oliver Klee commented on patch set 1 02/21/19, 15:13

    And can we have a regression test for this?
  5. Peter Kraume uploaded patch set 2 02/21/19, 15:19

  6. Peter Kraume updated the commit message in patch set 3 02/21/19, 15:20

  7. TYPO3com voted on patch set 2 V +1 02/21/19, 15:31 Completed build in 11m 07s on Thu, 21 Feb, 04:31 PM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32329

  8. TYPO3com voted on patch set 3 V +1 02/21/19, 15:33 Completed build in 13m 13s on Thu, 21 Feb, 04:33 PM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32330

  9. Anja Leichsenring updated the commit message in patch set 4 02/23/19, 14:26

  10. TYPO3com voted on patch set 4 V +1 02/23/19, 14:39 Completed build in 12m 47s on Sat, 23 Feb, 03:39 PM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32342

  11. Benni Mack voted on patch set 4 CR +1 02/28/19, 21:01

  12. Frank Nägler voted on patch set 4 V +1 CR +1 03/01/19, 14:38

  13. Andreas Kienast voted on patch set 4 CR +1 03/01/19, 15:42

  14. Wouter Wolters voted on patch set 4 CR +1 03/01/19, 22:59

  15. Benni Mack voted on patch set 4 V +2 CR +2 03/04/19, 13:53

  16. Benni Mack merged patch set 5 03/04/19, 13:54