Review main Merged

59795[BUGFIX] Ensure redirectUrl is a string

Andreas Wolf CR +2 V +2 Easy +3 −3 updated 03/01/19, 14:57

Commit message

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Andreas Wolf uploaded patch set 1 02/24/19, 15:56

  2. TYPO3com voted on patch set 1 V +1 02/24/19, 16:06 Completed build in 09m 58s on Sun, 24 Feb, 05:06 PM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32388

  3. Oliver Klee commented on patch set 1 02/24/19, 16:20

    Are 9.5 and 8.7 affected as well?

    FrontendLoginController.php:160

    Should we also have a cast for return_url?
  4. Andreas Wolf commented on patch set 1 02/24/19, 17:09

    Reply

    No, that code was introduced in master only.

    FrontendLoginController.php:160 Reply

    Not necessary IMO, as return_url is only used if set due to the ?: operator. AFAIK, _GP() will only ever return strings or NULL.
  5. Oliver Klee voted on patch set 1 CR +1 02/24/19, 17:55

  6. Benni Mack voted on patch set 1 V +1 CR +2 02/28/19, 20:39

  7. Frank Nägler voted on patch set 1 V +2 CR +2 03/01/19, 14:57

  8. Frank Nägler merged patch set 2 03/01/19, 14:57