59886[BUGFIX] Reduce strictness for .pl files in fileDenyPattern
Commit message
Review
-
Code review CR +2 Done
- Markus Klein +2
- Wolfgang Klinger +1
- Anja Leichsenring +1
- Susi Moog +1
-
Verified V +2 Done
- Markus Klein +2
- Anja Leichsenring +1
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1317
-
Oliver Hader uploaded patch set 1 03/06/19, 16:53
-
Oliver Hader uploaded patch set 2 03/06/19, 17:01
-
TYPO3com voted on patch set 1 V +1 03/06/19, 17:03 Completed build in 10m 08s on Wed, 6 Mar, 06:03 PM Test Summary: 47152 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32559
-
Oliver Hader updated the commit message in patch set 3 03/06/19, 17:12
-
TYPO3com voted on patch set 2 V +1 03/06/19, 17:16 Completed build in 15m 06s on Wed, 6 Mar, 06:16 PM Test Summary: 47152 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32560
-
Markus Klein uploaded patch set 4 03/06/19, 17:21
-
Markus Klein voted on patch set 4 CR +1 03/06/19, 17:21
-
Markus Klein voted on patch set 4 V +1 03/06/19, 17:24
-
TYPO3com voted on patch set 3 V +1 03/06/19, 17:29 Completed build in 16m 32s on Wed, 6 Mar, 06:29 PM Test Summary: 47152 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32561
-
TYPO3com voted on patch set 4 V +1 03/06/19, 17:36 Completed build in 14m 32s on Wed, 6 Mar, 06:36 PM Test Summary: 47152 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32562
-
Wolfgang Klinger commented on patch set 4 CR +1 03/06/19, 18:23
Thanks! -
Anja Leichsenring voted on patch set 4 V +1 CR +1 03/06/19, 19:00
-
Susi Moog voted on patch set 4 V +1 CR +1 03/07/19, 18:35
-
Oliver Klee commented on patch set 4 03/07/19, 18:42
SystemEnvironmentBuilder.php:136Then the bugs would still affect file like "foo.php.txt", or am I mistaken? -
Markus Klein commented on patch set 4 03/07/19, 20:50
SystemEnvironmentBuilder.php:136ReplyCorrect. But it is more likely to encounter a `AddHandler .php` default configuration of apache than with .pl. Moreover it is still more likely to have a .pl.* file due to the nature of PL being a language code. I'm fine with this solution. -
Markus Klein voted on patch set 4 V +2 CR +2 03/07/19, 20:52
-
Markus Klein merged patch set 5 03/07/19, 20:53