Review main Merged

60032[BUGFIX] Use correct default value for sys_file_storage|is_public

Georg Ringer CR +2 V +2 Easy +1 −1 updated 03/11/19, 10:32

Commit message

Use 1 instead of true as default value.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Stefan Froemken +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Stefan Froemken +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Georg Ringer uploaded patch set 1 03/11/19, 06:13

  2. Georg Ringer commented on patch set 1 03/11/19, 06:14

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 03/11/19, 06:26 Completed build in 12m 52s on Mon, 11 Mar, 07:26 AM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32646

  4. Josef Glatz voted on patch set 1 V +1 CR +1 03/11/19, 06:49

  5. Stefan Froemken commented on patch set 1 V +1 CR +1 03/11/19, 10:29

    Default value of TCA:is_public is casted to bool in UserSysFileStorageIsPublicElement, so there is no need for further changes. Thank you Georg.
  6. Benni Mack voted on patch set 1 V +2 CR +2 03/11/19, 10:32

  7. Benni Mack merged patch set 2 03/11/19, 10:32