Review main Merged

60263[BUGFIX] Add additionalFields to cache identifier in getPageForRootline

Wolfgang Klinger CR +2 V +2 Easy +2 −2 updated 03/17/19, 15:00

Commit message

Otherwise, consecutive calls with additional fields given
will not return them.

Use md5 hash for the additionalFields in getPageForRootline and
BEgetRootLine.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Daniel Goerz +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1114

  1. Wolfgang Klinger uploaded patch set 1 03/15/19, 16:14

  2. TYPO3com voted on patch set 1 V +1 03/15/19, 16:30 Completed build in 15m 58s on Fri, 15 Mar, 05:30 PM Test Summary: 47215 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32769

  3. Georg Ringer voted on patch set 1 V +1 CR +1 03/15/19, 17:21

  4. Benni Mack commented on patch set 1 03/15/19, 17:23

    BackendUtility.php:409 Unresolved

    lets use a md5() on the imploded string, or json_encode() on the array. otherwise identifier could become too large for the identifiers in the DB... (just a edge case, but - you know... better safe than another patch...)
  5. Georg Ringer uploaded patch set 2 03/15/19, 21:25

  6. Georg Ringer voted on patch set 2 V +1 CR +1 03/15/19, 21:26

  7. Wolfgang Klinger uploaded patch set 3 03/15/19, 21:38

  8. TYPO3com voted on patch set 2 V +1 03/15/19, 21:40 Completed build in 14m 34s on Fri, 15 Mar, 10:40 PM Test Summary: 47215 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32774

  9. Wolfgang Klinger commented on patch set 3 03/15/19, 21:40

    OK, I added the same hash for generating the other key in BEgetRootLine
  10. TYPO3com voted on patch set 3 V +1 03/15/19, 21:53 Completed build in 14m 26s on Fri, 15 Mar, 10:53 PM Test Summary: 47215 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32775

  11. Benni Mack voted on patch set 3 V +1 CR +1 03/16/19, 21:44

  12. Daniel Goerz voted on patch set 3 CR +1 03/17/19, 13:31

  13. Benjamin Franzke voted on patch set 3 V +2 CR +2 03/17/19, 14:59

  14. Benjamin Franzke merged patch set 4 03/17/19, 15:00