Review main Abandoned

60265[WIP][BUGFIX] Fix site resolution for versioned page moves across sites

Benjamin Franzke CR 0 V 0 Normal +69 −32 updated 11/04/21, 14:42

Commit message

The site finder is now able to derive sites by the uid of
a possible workspace move pointer record (VersionState::MOVE_POINTER).
The logic is implemented behind the scenes in PageRepository
and RootlineUtility.

PageRepository is adapted to properly invoke getMovePlaceholder()
using the original uid (t3ver_oid), instead of the move pointer record uid
(BackendUtility:fixVersioningPid already does so as well).

TODO:
 * Split wrong call from PageRepository::fixVersioningPid to
   getMovePlaceholder() into a separate patch
   (PageRepository::fixVersioningPid is broken, while
   BackendUtility::fixVersioningPid is not)
 * Should we renmame movePlhOL (=movePlaceholderOverlay) to a different
   name (covering both MOVE_PLACEHOLDER and MOVE_POINTER), e.g.
   moveOverlay
   Or should we move the functonality to handle MOVE_POINTER into a
   different function(?)
 * Maybe adapt BackendUtility::movePlhOl as well?
 * Add tests

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Files 2