Review 9.5 Merged

60271[BUGFIX] Ensure result is string in __toString of CropVariantCollection

Daniel Goerz CR +2 V +2 Easy +10 −1 updated 03/16/19, 12:10

Commit message

CropVariantCollection returns output from json_encode in its __toString
method. Json_encode may return false if it fails to properly encode the
given data (mostly when non-UTF8 data is given). To ensure that no
exception is thrown to the user in that case, the __toString method
has been adjusted to return the same result as in the empty variants case.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2