Review main Merged

60293[FEATURE] Introduce TCA type "language"

Benni Mack CR +2 V +2 Expert +1456 −871 updated 03/16/21, 21:39

Commit message

A new TCA type "language" is added, in order to make life easier
to set up new TCA. The main issue (as can be seen in core already)
is that each TCA adds different implementations on how to deal with
"-1". Now "-1" is added for any record except "pages", where the
"-1 / All Languages" concept is not implemented.

In addition, this decouples the select type from sys_language,
effectively reducing the logic where a direct access is necessary
to the "sys_language" table.

This effectively also removes the now mis-use of `foreign_table`
from the TCA "languageField" field by properly handling languages
internally. This furthermore makes any relation handling superfluous,
reducing quite an amount of code and complexity in the DataHandler.

Instead, all columns, defined as "[ctrl][languageField]", are now
automatically migrated to the new "type=language", with no specific
configuration, as TYPO3 is managing this field, taking care of the
user specific configuration.

Furthermore, are all columns, using the “special=languages” option,
migrated to the new TCA type. This allows to get rid of this special
case as well, reducing complexity in FormEngine and DataHandler.

The new TCA type also properly handles the field for records on
root level, or on a page outside of a site context. The only
exception is the `allowed_languages` field in be_users and
be_groups, where a new itemsProcFunc is used.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 204

Show 184 more files