Review main Merged

60337[BUGFIX] Use SiteFinder in SearchController for getting all languages

Georg Ringer CR +2 V +2 Easy +12 −12 updated 04/05/19, 15:50

Commit message

The SiteFinder must be used instead of only fetching all languages from
sys_language.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Mona Muzaffar +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Mona Muzaffar +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 912

  1. Georg Ringer uploaded patch set 1 03/25/19, 21:00

  2. Georg Ringer commented on patch set 1 03/25/19, 21:00

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 03/25/19, 21:15 Completed build in 14m 40s on Mon, 25 Mar, 10:15 PM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32965

  4. Benni Mack uploaded patch set 2 03/26/19, 06:50

  5. TYPO3com voted on patch set 2 V +1 03/26/19, 07:06 Completed build in 15m 34s on Tue, 26 Mar, 08:06 AM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32967

  6. Mona Muzaffar commented on patch set 2 04/05/19, 12:09

    Is this more of a rewrite than a bugfix? Or could you please add a bug description in the ticket to explain how to test this patch and what change one should expect?
  7. Andreas Kienast commented on patch set 2 V -1 04/05/19, 14:03

    Call to undefined method TYPO3\CMS\Core\Routing\SiteMatcher::getSiteByPageId()
  8. Andreas Kienast uploaded patch set 3 04/05/19, 14:05

  9. Mona Muzaffar voted on patch set 3 V +1 CR +1 04/05/19, 14:15

  10. TYPO3com voted on patch set 3 V +1 04/05/19, 14:22 Completed build in 14m 35s on Fri, 5 Apr, 04:22 PM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33071

  11. Anja Leichsenring voted on patch set 3 V +2 CR +2 04/05/19, 15:50

  12. Anja Leichsenring merged patch set 4 04/05/19, 15:50