Review 9.5 Merged

60361[BUGFIX] Ensure route defaults and requirements are considered

Oliver Hader CR +2 V +2 Hard +738 −34 updated 01/28/20, 10:23

Commit message

Changes concerning route `defaults`:
+ defaults are mapped now (e.g. `1` <=> `one`)
+ defaults are applied now when having multiple parameters in a
  route path (e.g. `{default}/{required}`
+ defaults are applied now for types `Plugin` and `Extbase`
  (type `Simple` worked in most cases)
+ enforced defaults are considered now (e.g. `{!default}`
+ `Route` instances get `_appliedDefault` option set now - which
  contains deflated values and still needs to be inflated manually

Changes concerning route `requirements`:
+ requirements are deflated now for being processed as Symfony routes
  (resulting in requirements being correctly applied now in enhancers)
+ requirements are skipped now for parameters having corresponding
  aspects defined ("aspects take precedence over requirements")

References:
+ https://symfony.com/blog/new-in-symfony-4-3-always-include-route-default-values
+ https://symfony.com/doc/4.3/routing.html#parameters-validation
+ https://symfony.com/doc/4.3/routing.html#optional-parameters

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 12