Review main Merged

60420[BUGFIX] Catch TypeError on inlineCSS files

Benni Mack CR +2 V +2 Easy +4 −2 updated 04/12/19, 18:07

Commit message

If page.includeCSS.myfile.import = 1 is used, but no "media" is set, a TypeError
is thrown, which is now caught and properly checked.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Tobi Kretschmann +1
    • Julian Geils +1
  • Verified V +2 Done
    • Benni Mack +2
    • Tobi Kretschmann +1
    • Julian Geils +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Benni Mack uploaded patch set 1 04/09/19, 02:01

  2. TYPO3com voted on patch set 1 V +1 04/09/19, 02:12 Completed build in 11m 17s on Tue, 9 Apr, 04:12 AM Test Summary: 47267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33125

  3. Julian Geils voted on patch set 1 V +1 CR +1 04/09/19, 08:14

  4. Tobi Kretschmann commented on patch set 1 V +1 CR +1 04/12/19, 12:31

    tested in 9.5 and master
  5. Benni Mack voted on patch set 1 V +2 CR +2 04/12/19, 18:07

  6. Benni Mack merged patch set 2 04/12/19, 18:07