Review 9.5 Merged

60457[BUGFIX] Catch TypeError on inlineCSS files

Benni Mack CR +2 V +2 Easy +4 −2 updated 04/12/19, 18:30

Commit message

If page.includeCSS.myfile.import = 1 is used, but no "media" is set, a TypeError
is thrown, which is now caught and properly checked.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 35

  1. Benni Mack commented on patch set 1 04/12/19, 18:07

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 04/12/19, 18:23 Completed build in 16m 12s on Fri, 12 Apr, 08:23 PM Test Summary: 1 of 50442 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-493

  3. TYPO3com voted on patch set 1 V +1 04/12/19, 18:29 Completed build in 38m 28s on Fri, 12 Apr, 08:29 PM Test Summary: 49974 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-493

  4. Benni Mack voted on patch set 1 V +2 CR +2 04/12/19, 18:30

  5. Benni Mack merged patch set 2 04/12/19, 18:30