Review main Merged

60462[BUGFIX] Menu of updated pages skips current page

Benni Mack CR +2 V +2 Easy +7 −2 updated 07/01/19, 04:27

Commit message

When using beginAtLevel = 1 is set, then HMENU
should not include the current page at all, so this
is now fixed by "getTreeList" handing in a positive
page ID.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Daniel Gorges +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Riccardo De Contardi +1
    • Daniel Gorges +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Benni Mack uploaded patch set 1 04/13/19, 05:47

  2. TYPO3com voted on patch set 1 V +1 04/13/19, 06:00 Completed build in 12m 50s on Sat, 13 Apr, 08:00 AM Test Summary: 47343 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33231

  3. Riccardo De Contardi commented on patch set 1 V +1 04/13/19, 10:21

    Tested on Master with the code provided on https://forge.typo3.org/issues/23255 I tested that 1) _before_ the patch, the starting page `special.value = X` is still present in the HMENU 2) _after_ the patch, the starting page is absent from the menu, and only the subpages `special.beginAtLevel = 1` are considered
  4. Daniel Goerz voted on patch set 1 V +1 CR +1 06/28/19, 18:51

  5. Daniel Gorges voted on patch set 1 V +1 CR +1 07/01/19, 04:21

  6. Benni Mack voted on patch set 1 V +2 CR +2 07/01/19, 04:27

  7. Benni Mack merged patch set 2 07/01/19, 04:27