Review 9.5 Merged

60560[TASK] Raise twitter bootstrap to 3.4.1

Andreas Kienast CR +2 V +2 Easy +8 −8 updated 04/26/19, 08:26

Commit message

To ensure that we incorporate the latest known
vulnerabilities and issues in Twitter Bootstrap 3.x,
the dependency is updated.

Executed tasks:
  cd Build
  yarn add bootstrap-sass@^3.4.1 --dev
  yarn exec grunt

Then copying the contents of Build/node_modules/bootstrap-sass/assets/javascripts/bootstrap.min.js
into typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap/bootstrap.js
additionally adding the AMD factory wrapper.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3