Review main Abandoned

60634[BUGFIX] Prevent page is being generated message being shown

Helmut Hummel CR 0 V 0 Easy +0 −3 updated 05/05/19, 10:59

Commit message

The reason this message is show for the second of two concurrent
requests is, that the pagesection lock is released after
pagesection cache is generated, but before page rendering
completed.

Since writing a temporary page cache is part of the
page cache generation, second request could hit
after the temporary cache has been written and pulling in
the temporary cache entry and delivering that to the client.

We now only release the pagesection lock 
after the page rendering completes, which means for the first
hit after empty caches all further requests wait until the
page rendering completed (and temporary cache is deleted and
replaced with the real cache entry), thus deliver the correct
cache entry.

This basically restores the locking behavior to a state
before TYPO3 7.6, where the additional release was introduced.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1