Review main Merged

60638[BUGFIX] Proper form definition validation if backend language changes

Ralf Zimmermann CR +2 V +2 Normal +193 −33 updated 10/26/19, 09:09

Commit message

If a form element property is not defined through a form editor
inspector, the "predefinedDefaults" value from the form editor setup
will be used for some data integrity checks (such properties are
immutable).

Now, such checks against the "predefinedDefaults" values are *only* used
in scenarios where form elements are newely created. All the following
integrety checks on this value will be based on hmac validation.

In addition, this patchset fixes a faulty validation in the following
(edgy) scenario:

* backend language is EN
* open the form edtior and add a ContentElement form element
* switch to another browser tab and change the backend language to DE
* clear the cache
* go back to the form editor and click the save button

This is done by getting all translations (for all backend languages)
for the untranslated! "predefinedDefaults" value and compare the
(already translated) value (from the form definition) against the
possible translations from "predefinedDefaults".

There is an extended scenario which is out of scope for fixing:

* the same scenario as above + delete the previous chosen backend
  language within the maintenance tool

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 8