Review main Abandoned

60643[BUGFIX] Skip mkdir on logfiles with wrapper.

Sven Carstens CR 0 V 0 Easy +11 −7 updated 05/03/19, 06:34

Commit message

Before creating the directories for the logfile we check
for wrapper usage via parse_url. If the file:// wrapper is used we remove
that before creating the directory hierarchy.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 57

  1. Sven Carstens uploaded patch set 1 05/02/19, 12:48

  2. Mathias Brodala commented on patch set 1 CR -1 05/02/19, 12:52

    FileWriter.php:221 Unresolved

    We should use parse_url here instead. Also yoda conditions we don't use. ;-)
  3. TYPO3com voted on patch set 1 V -1 05/02/19, 12:58 Completed build in 09m 25s on Thu, 2 May, 02:58 PM Test Summary: 36 of 47868 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33693

  4. Sven Carstens updated the commit message in patch set 2 05/03/19, 05:45

  5. TYPO3com voted on patch set 2 V -1 05/03/19, 05:58 Completed build in 13m 31s on Fri, 3 May, 07:58 AM Test Summary: 36 of 47868 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33698

  6. Sven Carstens commented on patch set 2 05/03/19, 06:34

    > Patch Set 1: Code-Review-1 > > (1 comment) Messed up my local git. Change is now in https://review.typo3.org/c/Packages/TYPO3.CMS/+/60646
  7. Sven Carstens abandoned the change 05/03/19, 06:34