Review main Merged

60719[BUGFIX] Ignore PATH_INFO in NormalizedParams scriptName calculation

Benni Mack CR +2 V +2 Normal +51 −17 updated 05/13/19, 04:12

Commit message

When NormalizedParams was introduced, the code that was refactored from
GeneralUtility:getIndpEnv did not take into account that PATH_INFO
could be set, but be empty. (which happens with the Debian 9 NGINX
default configuration which uses `fastcgi_split_path_info` and set's
`fastcgi_param PATH_INFO` even if it's empty).

Now, the fallback to PATH_INFO has been introduced with
the initial revision of TYPO3 and isn't needed at all nowadays,
it's actually wrong, as a REQUEST_URI to /index.php/foo/bar
would incorrectly be interpreted as $scriptName == "/foo/bar".

This patch additionally replaces PATH_INFO with SCRIPT_NAME in
test cases where this variable is actually wrong (we assume test cases
have been modeled to match (old) code, instead of reality here):

 * ProxyPass does not result in PATH_INFO being set,
   it's SCRIPT_NAME here.
 * PATH_INFO is not set for regular request
   to /typo3/index.php

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3