Review 9.5 Merged

60782[BUGFIX] Use VersionState constants instead of numbers

Benni Mack CR +2 V +2 Easy +7 −5 updated 05/20/19, 15:21

Commit message

A few places still use t3ver_state instead of the available
constants in VersionState. To increase
the semantics of the used code, the constants are used
instead.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 810

  1. Benni Mack commented on patch set 1 05/20/19, 14:04

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/workspaces/Classes/Hook/DataHandlerHook.php
  2. TYPO3com voted on patch set 1 V -1 05/20/19, 14:04 Completed build in 12s on Mon, 20 May, 04:04 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-718

  3. Benni Mack abandoned the change 05/20/19, 14:04

  4. Benni Mack restored the change 05/20/19, 14:06

  5. Benni Mack commented on patch set 1 05/20/19, 14:07

    This change is ready for review.
  6. Benni Mack uploaded patch set 2 05/20/19, 14:07

  7. Oliver Klee voted on patch set 2 CR +1 05/20/19, 14:07

  8. TYPO3com voted on patch set 2 V +1 05/20/19, 14:20 Completed build in 13m 43s on Mon, 20 May, 04:20 PM Test Summary: 50341 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-719

  9. Benni Mack voted on patch set 2 V +2 CR +2 05/20/19, 15:21

  10. Benni Mack merged patch set 3 05/20/19, 15:21